Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to remove site switcher from header #1132

Merged
merged 2 commits into from
Jun 8, 2021
Merged

feat: add option to remove site switcher from header #1132

merged 2 commits into from
Jun 8, 2021

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Jun 7, 2021 •
edited
Loading

Closes #1131

Adds isSwitcherEnabled theme option to control Switcher button/menu inclusion (defaults to true)

@vpicone vpicone requested review from a team, aledavila and sstrubberg and removed request for a team June 7, 2021 18:14
@vercel
Copy link

vercel bot commented Jun 7, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/GnX4Myzxtm29GN8tnE5B6XyYSxgX
✅ Preview: https://gatsby-theme-c-git-fork-vpicone-switcher-option-carbon-d-aae7b3.vercel.app

@vpicone vpicone mentioned this pull request Jun 7, 2021
Closed
@vpicone vpicone changed the title docs: add documentation for switcher disabling feat: add option to remove site switcher from header Jun 7, 2021
vpicone
vpicone commented Jun 7, 2021
View reviewed changes
packages/example/src/pages/guides/configuration.mdx
@@ -259,9 +259,8 @@ plugins: [

- `mdxExtensions` – change the file extensions processed by `gatsby-mdx`
(default ['.mdx', '.md']).
- `pngCompressionSpeed` - a speed/quality trade-off from 1 (brute-force) to 10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option doesn't work any more, removing the documentation ahead of actually removing it in the next major.

@vpicone vpicone merged commit 06ab644 into carbon-design-system:main Jun 8, 2021
@vpicone vpicone deleted the switcher-option branch June 8, 2021 15:21
This was referenced May 18, 2024
Open
Open
This was referenced May 21, 2024
Open
Open
@mjperrins mjperrins mentioned this pull request May 23, 2024
Open
@seansund seansund mentioned this pull request May 24, 2024
Open
This was referenced May 25, 2024
Open
Open
This was referenced May 26, 2024
Open
Open
This was referenced May 27, 2024
Open
Open
@seansund seansund mentioned this pull request May 30, 2024
Open
@mjperrins mjperrins mentioned this pull request May 30, 2024
Open
This was referenced May 30, 2024
Open
Open
This was referenced Aug 2, 2024
Open
Open
Open
Open
Open
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 16, 2024
Open
Open
Open
Open
This was referenced Aug 23, 2024
Open
Open
Open
This was referenced Aug 31, 2024
Open
Open
Open
This was referenced Sep 7, 2024
Open
Open
This was referenced Sep 10, 2024
Open
Open
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
@seansund seansund mentioned this pull request Sep 24, 2024
Open
@seansund seansund mentioned this pull request Oct 3, 2024
Open
@mjperrins mjperrins mentioned this pull request Nov 2, 2024
Open
@seansund seansund mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@aledavila aledavila Awaiting requested review from aledavila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide option to turn off/disable Switcher
2 participants
@vpicone @sstrubberg